feat(pgpm): use built-in SkillInstaller for fast skill installation#1276
Merged
Conversation
Replace npx skills add with genomic's SkillInstaller as the default skill installation method. Uses shallow git clone + direct file copy with caching — much faster than the npx path. - Default: SkillInstaller (shallow clone, cached, ~2s) - --use-skills flag: opt into npx skills add (slower, writes skills-lock.json) - Re-exports SkillInstaller from @pgpmjs/core for downstream consumers - Threads --use-skills through all init paths (workspace, module, boilerplate)
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This comment has been minimized.
This comment has been minimized.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
npx skills addwith genomic'sSkillInstalleras the default skill installer inpgpm init. The old npx path is available via--use-skillsflag.Why:
npx skills addwas slow (~30s+) — it downloads theskillsnpm package, clones the entire source repo, then copies files.SkillInstallerdoes a single shallow clone (cached for 7 days) and copies.agents/skills/<name>/directly. Subsequent installs from the same source are instant.Changes:
installSkills()now dispatches toinstallSkillsBuiltin()(default) orinstallSkillsViaNpx()(with--use-skills):--use-skillsflag threaded through all init paths:handleInit→handleWorkspaceInit/handleModuleInit/handleBoilerplateInit.Re-exports
SkillInstaller,SkillInstallOptions,SkillInstallResult,SkillInstallFailurefrom@pgpmjs/corefor downstream consumers.PGPM_SKIP_SKILL_INSTALLenv var added for deterministic testing (same pattern asPGPM_SKIP_UPDATE_CHECK).Depends on: dev-utils#88 (merged) — adds
SkillInstallerto genomic. Requires genomic@5.6.0.Link to Devin session: https://app.devin.ai/sessions/8a70e4bc95b947faa41db21e02ed818e
Requested by: @pyramation